amogh-jahagirdar commented on code in PR #18604:
URL: https://github.com/apache/iceberg/pull/18604#discussion_r4342967903


##########
core/src/main/java/org/apache/iceberg/StatsUtil.java:
##########
@@ -325,4 +336,181 @@ private static boolean isScalar(Schema schema, 
Map<Integer, Integer> parentIndex
 
     return true;
   }
+
+  /** Inclusive source column bounds for a partition value. Upper is null when 
unbounded. */
+  record PartitionSourceBounds(Object lower, Object upper) {}

Review Comment:
   I didn't put a tightness flag on these bounds since I think it makes more 
sense for the adapter to set it. These bounds describe which source values a 
partition value allows, while tightness is a statement about the actual values 
in a file's stats, so it belongs with the adapter that builds those stats, 
especially now that we're talking about file level tightness.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to