richiebachala commented on PR #2190: URL: https://github.com/apache/iceberg-go/pull/2190#issuecomment-6324142194
Thanks both. Reworked per option 1 in 6734162: - `TestPolarisCatalogConformance` is now `TestExternalRestCatalogConformance`, configured by `REST_CATALOG_URI` and optional `_CREDENTIAL`, `_SCOPE` & `_WAREHOUSE`. - `make integration-setup-polaris` and `make integration-external-rest` default to Polaris; overriding the env vars points it at any other REST catalog. - CI runs it on the Spark 3.5 leg of Go Integration (Polaris does not depend on Spark), and prints the Polaris logs on failure. Checked locally: 27/27 pass against Polaris, and 27/27 against the Java fixture with every override cleared, so the any-catalog path works. I also merged main into the branch rather than rebasing, to keep the reviewed commits intact. PR description updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
