zeroshade opened a new pull request, #2262: URL: https://github.com/apache/iceberg-go/pull/2262
### Problem `dev/check-api-compat.sh` runs `apidiff -m` over the whole module, which includes `package main` directories. Those cannot be imported, so their exported identifiers are not public API. #2260 fails the check for adding a method to `cmd/iceberg`'s `Output` interface: ``` - ./cmd/iceberg.Output.PlannedFiles: added ``` ### Fix After apidiff runs, the script lists the module's `package main` directories with `go list` and drops findings for them (apidiff prints them as `- ./<dir>.<name>: ...`). Everything else is unchanged. ### Testing Against `main`, with #2260's tree: - unchanged: "No incompatible API changes", exit 0 (previously exit 1 on the line above). - with an added parameter on `compaction.Analyze` as well: the `./table/compaction.Analyze` change is still reported, exit 1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
