stevenzwu commented on code in PR #16425: URL: https://github.com/apache/iceberg/pull/16425#discussion_r4342252418
########## format/spec.md: ########## @@ -1221,7 +1222,7 @@ For example, an `events` table with a timestamp column named `ts` that is partit The inclusive projection for an unknown partition transform is _true_ because the partition field is ignored and not used in filtering. -Data files that match the query filter must be read by the scan. +Data files that match the query filter must be read by the scan. Data files with column files must be read as described in [Column Updates](#column-updates). Review Comment: similar to [my earlier comment](https://github.com/apache/iceberg/pull/16425/changes#r4342208473). we probably don't need to qualify the "data files" everywhere. maybe a single place would be sufficient. ########## format/spec.md: ########## @@ -1291,6 +1292,8 @@ When expiring snapshots, retention policies in table and snapshot references are A file may be deleted from the file system when the snapshot in which it was deleted is garbage collected, assuming that the file is not live in any remaining snapshot [1]. +A [column file](#column-updates) is live in a snapshot if a live entry in that snapshot has it in `column_files`. A column file may be deleted from the file system when it is not live in any remaining snapshot. Review Comment: +1. I think we can remove this paragraph. the previous paragraph at line 1293 covers this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
