pvary commented on code in PR #17610:
URL: https://github.com/apache/iceberg/pull/17610#discussion_r4337273323


##########
data/src/test/java/org/apache/iceberg/data/ReadFormatModelTests.java:
##########
@@ -145,6 +163,29 @@ private Schema filterUnsupported(Schema schema) {
     return kept.size() == schema.columns().size() ? schema : new Schema(kept);
   }
 
+  protected void assumeSupportedTypes(Schema schema) {
+    Collection<Type.TypeID> unsupportedTypeIds = unsupportedTypeIds();
+
+    Type unsupportedType =
+        TypeUtil.find(schema, type -> 
unsupportedTypeIds.contains(type.typeId()));

Review Comment:
   This checks for the main struct as well which will be skipped because 
vectorized read doesn't support structs ATM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to