Revanth14 opened a new pull request, #2247: URL: https://github.com/apache/iceberg-go/pull/2247
## Problem Follow-up to #2216. `wantResidual` was set only on the `partition` row, and it compared with `assert.Equal`, which works only for a residual that needs no binding. ## Fix `wantResidual` is now compared after binding both sides, as `assertPlanningParity` already does for local vs remote residuals, with a nil residual meaning the filter. It is set on `and residual` and `metrics` (`renamed > 25`) and on `set`, `not` and `case insensitive` (`AlwaysTrue`). `or` is left unset because its residual differs per file. ## Testing Test-only change. The new expectations pass in the inline, fanout and async modes, and changing `and residual` to expect `renamed > 26` fails all three. gofmt, `go vet ./...` and `go test -race ./...` pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
