Copilot commented on code in PR #3495:
URL: https://github.com/apache/iceberg-rust/pull/3495#discussion_r4330258842
##########
Cargo.toml:
##########
@@ -149,4 +149,4 @@ uuid = { version = "1.18", features = ["v7"] }
volo = "0.10.6"
volo-thrift = "0.10.8"
zeroize = "1.7"
-zstd = "0.13.3"
+zstd = { version = "0.13.3", default-features = false }
Review Comment:
Disabling default features on `zstd` is non-obvious and changes supported
input formats (e.g., dropping pre-1.0/legacy frame decode support). Add a short
inline comment explaining the rationale (license/footprint) and the assumption
that no supported formats require legacy zstd frames, so this doesn't get
reverted unintentionally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
