yusufyildiz34 commented on PR #18579: URL: https://github.com/apache/iceberg/pull/18579#issuecomment-6301458739
@singhpk234! Thanks for the review. The null isn't coming from the provider: `credentialsProvider()` adds `credentials.uri` to the map it hands to the custom provider even when no refresh endpoint is configured. A provider that builds its own `AwsClientProperties` from that map, like the one in the issue, then fails inside Iceberg itself, in `PropertyUtil.filterProperties`, because `Collectors.toMap` rejects null values. Handling it in the provider would mean every implementation has to strip nulls before calling the Iceberg API, so skipping the key when there's no endpoint seemed better, and it matches what the `VendedCredentialsProvider` branch right below already does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
