kevinjqliu commented on code in PR #4017:
URL: https://github.com/apache/iceberg-python/pull/4017#discussion_r4328594381
##########
dev/docker-compose-integration.yml:
##########
@@ -62,27 +62,24 @@ services:
- CATALOG_S3_ENDPOINT=http://object-store:9000
- CATALOG_JDBC_STRICT__MODE=true
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: pyiceberg-object-store
networks:
iceberg_net:
aliases:
- warehouse.object-store
ports:
- - 9001:9001
- 9000:9000
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- - RUSTFS_VOLUMES=/data
- - RUSTFS_ADDRESS=:9000
- - RUSTFS_CONSOLE_ENABLE=true
- - RUSTFS_CONSOLE_ADDRESS=:9001
+ - RUSTFS_OBS_LOG_STDOUT_ENABLED=true
+ - RUSTFS_CONSOLE_ENABLE=false
Review Comment:
removes console port 9001, we dont need it
##########
dev/docker-compose-integration.yml:
##########
@@ -62,27 +62,24 @@ services:
- CATALOG_S3_ENDPOINT=http://object-store:9000
- CATALOG_JDBC_STRICT__MODE=true
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: pyiceberg-object-store
networks:
iceberg_net:
aliases:
- warehouse.object-store
ports:
- - 9001:9001
- 9000:9000
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- - RUSTFS_VOLUMES=/data
- - RUSTFS_ADDRESS=:9000
- - RUSTFS_CONSOLE_ENABLE=true
- - RUSTFS_CONSOLE_ADDRESS=:9001
+ - RUSTFS_OBS_LOG_STDOUT_ENABLED=true
Review Comment:
show logs in CI
##########
dev/docker-compose-integration.yml:
##########
@@ -62,27 +62,24 @@ services:
- CATALOG_S3_ENDPOINT=http://object-store:9000
- CATALOG_JDBC_STRICT__MODE=true
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: pyiceberg-object-store
networks:
iceberg_net:
aliases:
- warehouse.object-store
ports:
- - 9001:9001
- 9000:9000
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- - RUSTFS_VOLUMES=/data
- - RUSTFS_ADDRESS=:9000
- - RUSTFS_CONSOLE_ENABLE=true
- - RUSTFS_CONSOLE_ADDRESS=:9001
+ - RUSTFS_OBS_LOG_STDOUT_ENABLED=true
+ - RUSTFS_CONSOLE_ENABLE=false
# Resolves virtual-hosted-style `warehouse.object-store` to the warehouse
# bucket.
- RUSTFS_SERVER_DOMAINS=object-store
healthcheck:
- test: ["CMD-SHELL", "curl --fail http://127.0.0.1:9000/health";]
+ test: ["CMD-SHELL", "curl --fail http://127.0.0.1:9000/health/ready";]
Review Comment:
The RustFS [Status Check
docs](https://docs.rustfs.com/en/operations/status-check) define the two
endpoints differently:
- `/health` is a liveness check. It returns 200 "as long as the process is
up".
- `/health/ready` is a readiness check. It returns 200 "only when storage,
IAM, and peer health are ready", and 503 otherwise.
##########
dev/docker-compose-integration.yml:
##########
@@ -62,27 +62,24 @@ services:
- CATALOG_S3_ENDPOINT=http://object-store:9000
- CATALOG_JDBC_STRICT__MODE=true
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: pyiceberg-object-store
networks:
iceberg_net:
aliases:
- warehouse.object-store
ports:
- - 9001:9001
- 9000:9000
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- - RUSTFS_VOLUMES=/data
- - RUSTFS_ADDRESS=:9000
- - RUSTFS_CONSOLE_ENABLE=true
- - RUSTFS_CONSOLE_ADDRESS=:9001
Review Comment:
these are all defaults, can remove
##########
dev/docker-compose.yml:
##########
@@ -17,20 +17,17 @@
services:
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: pyiceberg-object-store
ports:
- - 9001:9001
- 9000:9000
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- - RUSTFS_VOLUMES=/data
- - RUSTFS_ADDRESS=:9000
- - RUSTFS_CONSOLE_ENABLE=true
- - RUSTFS_CONSOLE_ADDRESS=:9001
Review Comment:
these are all defaults, can remove
##########
dev/docker-compose.yml:
##########
@@ -17,20 +17,17 @@
services:
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: pyiceberg-object-store
ports:
- - 9001:9001
- 9000:9000
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- - RUSTFS_VOLUMES=/data
- - RUSTFS_ADDRESS=:9000
- - RUSTFS_CONSOLE_ENABLE=true
- - RUSTFS_CONSOLE_ADDRESS=:9001
+ - RUSTFS_OBS_LOG_STDOUT_ENABLED=true
+ - RUSTFS_CONSOLE_ENABLE=false
Review Comment:
removes console port 9001, we dont need it
##########
dev/docker-compose.yml:
##########
@@ -17,20 +17,17 @@
services:
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: pyiceberg-object-store
ports:
- - 9001:9001
- 9000:9000
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- - RUSTFS_VOLUMES=/data
- - RUSTFS_ADDRESS=:9000
- - RUSTFS_CONSOLE_ENABLE=true
- - RUSTFS_CONSOLE_ADDRESS=:9001
+ - RUSTFS_OBS_LOG_STDOUT_ENABLED=true
+ - RUSTFS_CONSOLE_ENABLE=false
healthcheck:
- test: ["CMD-SHELL", "curl --fail http://127.0.0.1:9000/health";]
+ test: ["CMD-SHELL", "curl --fail http://127.0.0.1:9000/health/ready";]
Review Comment:
The RustFS [Status Check
docs](https://docs.rustfs.com/en/operations/status-check) define the two
endpoints differently:
- `/health` is a liveness check. It returns 200 "as long as the process is
up".
- `/health/ready` is a readiness check. It returns 200 "only when storage,
IAM, and peer health are ready", and 503 otherwise.
##########
dev/docker-compose.yml:
##########
@@ -17,20 +17,17 @@
services:
object-store:
- image: rustfs/rustfs:1.0.0
+ image: rustfs/rustfs:1.0.3
container_name: pyiceberg-object-store
ports:
- - 9001:9001
- 9000:9000
environment:
- RUSTFS_ACCESS_KEY=admin
- RUSTFS_SECRET_KEY=password
- - RUSTFS_VOLUMES=/data
- - RUSTFS_ADDRESS=:9000
- - RUSTFS_CONSOLE_ENABLE=true
- - RUSTFS_CONSOLE_ADDRESS=:9001
+ - RUSTFS_OBS_LOG_STDOUT_ENABLED=true
Review Comment:
show logs in CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
