richiebachala opened a new pull request, #2237: URL: https://github.com/apache/iceberg-go/pull/2237
Closes #2168. Part of #1691. ## What Catalogs that set `SupportsNamespaceProperties: false` used to skip the 7 property-write conformance tests. Now they run a single `NamespacePropertiesNotSupported` test in their place, mirroring `RenameTableNotSupported` from #2165. It asserts that: - `CreateNamespace` with properties returns `iceberg.ErrNotImplemented` and leaves no namespace behind. - `UpdateNamespaceProperties`, both set & remove, returns `iceberg.ErrNotImplemented` and leaves `LoadNamespaceProperties` unchanged. `LoadNamespaceProperties` still runs for every catalog. ## Hadoop Both Hadoop errors now wrap `iceberg.ErrNotImplemented`, the same pattern as its `RenameTable`. The `UpdateNamespaceProperties` message changes from "not yet implemented" to "namespace properties are not supported", to match `CreateNamespace`: Hadoop namespaces are directories, so this is by design, not pending work. The unit tests now use `ErrorIs`. ## Testing - `go test ./catalog/...` and `golangci-lint` pass. `go vet -tags integration ./catalog/...` is clean. - Hadoop runs `NamespacePropertiesNotSupported`. SQL, REST & Hive set the flag to true, so they run the same 8 property tests as before. - Reverting the `hadoop.go` change makes the new test fail with `Target error should be in err chain`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
