manuzhang commented on code in PR #1026: URL: https://github.com/apache/iceberg-cpp/pull/1026#discussion_r4320241162
########## src/iceberg/util/macros.h: ########## @@ -21,15 +21,18 @@ /// \file iceberg/util/macros.h /// \brief Define common Iceberg utility macros. +/// +/// The macros name Iceberg symbols with their full namespace, so code outside namespace Review Comment: Done in 81321d16, thanks. `ICEBERG_CHECK_OR_DIE` now throws `::iceberg::IcebergError`. I also moved the test helpers into a namespace with its own nested `iceberg`, so the test fails to compile if any of these macros drops the leading `::`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
