Revanth14 commented on issue #2132: URL: https://github.com/apache/iceberg-go/issues/2132#issuecomment-6272071251
I looked at Java's row `Evaluator` for this: `in` returns false for a null value, so `notIn(null)` is true there, while `notEq` compares through `Comparator.naturalOrder()` and isn't null-safe. Java also binds a one-value `NOT_IN` to `NOT_EQ`, like we do, so it has the same split and doesn't settle which way to go. I'd propose SQL semantics: `NotIn` never matches NULL, for any number of values. That agrees with `NotEqual`, with the three-valued logic #2111 added to copy-on-write deletes, and it makes the `NotIn` half of #2133 correct as is (`AlwaysFalse` on a missing column). The change would be in the multi-value translation only, so a NULL input yields NULL instead of true. @zeroshade @laskoviymishka does that direction work for you? I'm happy to pick it up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
