pvary commented on code in PR #18539:
URL: https://github.com/apache/iceberg/pull/18539#discussion_r4311574100
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcCatalog.java:
##########
@@ -1067,6 +1072,41 @@ public void testRemoveProperties() {
assertThat(catalog.namespaceExists(testNamespace)).isTrue();
}
+ @Test
+ void metadataRefreshMaxRetries() {
Review Comment:
For now, use the same pattern as the other test in the file.
We do:
- new test class - package private and package private test methods, and no
test prefix
- old test class - stick to the pattern used there, and only change if there
only a few existing tests
##########
core/src/test/java/org/apache/iceberg/jdbc/TestJdbcViewCatalog.java:
##########
@@ -91,6 +104,34 @@ protected boolean supportsEmptyNamespace() {
return true;
}
+ @Test
+ void metadataRefreshMaxRetries() {
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
