fairytale0828 opened a new pull request, #1040:
URL: https://github.com/apache/iceberg-cpp/pull/1040

   ## Summary
   
   When a split selects no row groups, `EmptyRecordBatchReader::schema()` 
returns `nullptr`, causing output schema alignment to be skipped. Empty splits 
can then report `list` instead of `large_list`, ignoring the reader 
configuration or list types stored in `ARROW:schema`.
   
   Remove `EmptyRecordBatchReader` and use `GetRecordBatchReader` for both 
empty and non-empty splits. This preserves schema consistency while still 
returning end-of-stream immediately for empty splits.
   
   
   ## Test plan
   
   - Add five tests covering `use-large-list` enabled and disabled, stored list 
types, missing fields, nested field pruning and renaming, and projections 
without physical columns. Verify that empty-split schemas match the unsplit 
reader and the first `Next()` returns end-of-stream.
   - Four new tests fail without the fix; all five pass with it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to