smaheshwar-pltr commented on PR #4039: URL: https://github.com/apache/iceberg-python/pull/4039#issuecomment-6251737674
Hey @Fokko, good to see you again! Thanks for taking a look, I've now opened this PR up for review so things should be clearer. In response to https://github.com/apache/iceberg-python/pull/4039#issuecomment-5938785605, we're dealing with remote signing here not pre-signed URLs, and I've since added an integration test against RustFS where the signing endpoint is a mock that lets us verify the the body is as expected. To me, this seems sufficient. I've also updated the PR description to better describe the problem we're seeing currently 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
