shangxinli commented on code in PR #1003:
URL: https://github.com/apache/iceberg-cpp/pull/1003#discussion_r4304041645
##########
src/iceberg/util/json_util_internal.h:
##########
@@ -57,6 +57,10 @@ inline void SetOptionalStringField(nlohmann::json& json,
std::string_view key,
}
}
+/// \brief Dump a JSON document to a string, ignoring encoding errors.
+///
+/// Not intended for error messages: parse errors describe the offending key
+/// and JSON type instead of reproducing JSON values.
inline std::string SafeDumpJson(const nlohmann::json& json) {
Review Comment:
After this change SafeDumpJson has no callers left anywhere under src.
Deleting it would enforce the rule the new doc comment describes, instead of
leaving the helper around for the next error message to reach for.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
