amogh-jahagirdar commented on PR #18544: URL: https://github.com/apache/iceberg/pull/18544#issuecomment-6236579984
Also linking this here since it came up above. With a builder we shouldn't need a public `MutableBitmap` interface. The builder can hold the mutable state and `build()` just returns a `ManifestBitmap`, so the mutable type stays internal to `org.apache.iceberg.mumbling`. https://github.com/apache/iceberg/pull/18544#pullrequestreview-5558751585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
