gaborkaszab commented on code in PR #18486:
URL: https://github.com/apache/iceberg/pull/18486#discussion_r4294906787


##########
spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/source/BatchDataReader.java:
##########
@@ -106,7 +104,6 @@ protected CloseableIterator<ColumnarBatch> 
open(FileScanTask task) {
     InputFileBlockHolder.set(filePath, task.start(), task.length());
 
     InputFile inputFile = getInputFile(filePath);
-    Preconditions.checkNotNull(inputFile, "Could not find InputFile associated 
with FileScanTask");

Review Comment:
   Yes, `InputFilesDecryptor.getInputFiles(String)` has a Precondition to avoid 
returning null. Making the Precondition pointless here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to