kinolaev commented on code in PR #18507:
URL: https://github.com/apache/iceberg/pull/18507#discussion_r4294969837
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicTableUpdateOperator.java:
##########
@@ -87,13 +92,32 @@ public DynamicRecordInternal map(DynamicRecordInternal
data) throws Exception {
data.spec(),
tableCreator);
TableMetadataCache.ResolvedSchemaInfo compareInfo = newData.f0;
+ Schema tableSchema = compareInfo.resolvedTableSchema();
- data.setSchema(compareInfo.resolvedTableSchema());
+ data.setEqualityFieldIds(remapFieldIds(data.equalityFields(),
data.schema(), tableSchema));
Review Comment:
I opened PR #18541. Once it gets merged, remapping will be on the hot path
only for one cache refresh interval after a schema change, as I assume it was
intended to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
