pvary commented on code in PR #18496:
URL: https://github.com/apache/iceberg/pull/18496#discussion_r4288357269
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/sink/IcebergWriteAggregator.java:
##########
@@ -89,6 +89,13 @@ public void open() throws Exception {
() -> table, table.properties(), flinkJobId, operatorId,
subTaskId, attemptId);
}
+ @Override
+ public void close() throws Exception {
+ try (tableLoader) {
Review Comment:
Why using `try (tableLoader)`?
This is the 3rd, or the 4th different close for our operators :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
