saths008 commented on PR #18445:
URL: https://github.com/apache/iceberg/pull/18445#issuecomment-6198684979

   👋 @RussellSpitzer as a follow up to the bug fix, I have this PR to use 
`InternalRow` like you suggested 
[here](https://github.com/apache/iceberg/pull/18209#issuecomment-6023979954). 
This looks to have a nice perf improvement in terms of latency and allocation 
(during testing saw 26%-42% less allocation).
   
   Also as a benefit, we can use Spark's equality checks rather than rolling 
out our own
   
   Would appreciate a look when you get some time! Thanks 🫡 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to