dannycjones commented on code in PR #3414:
URL: https://github.com/apache/iceberg-rust/pull/3414#discussion_r4285525256
##########
dev/release/licenses.py:
##########
@@ -68,6 +351,12 @@ def command_check_dependencies(_args: argparse.Namespace)
-> None:
if result.returncode != 0:
raise Failure("cargo-deny rejected the dependency licenses.")
+ declared = declared_clarifications()
+ evaluated, clarified = evaluated_crates()
+
+ require_clarifications_applied(declared, evaluated, clarified)
+ require_no_stale_clarifications(declared, evaluated)
Review Comment:
OK I'm just going to run it once, I think its clearer logically even if we
lose the better human-readable output.
Ideally, this is failing very very rarely...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]