ggershinsky commented on code in PR #18481:
URL: https://github.com/apache/iceberg/pull/18481#discussion_r4280483761
##########
data/src/main/java/org/apache/iceberg/data/GenericReader.java:
##########
@@ -84,13 +83,15 @@ private CloseableIterable<Record> applyResidual(
return records;
}
- private CloseableIterable<Record> openFile(FileScanTask task, Schema
fileProjection) {
- InputFile input = io.newInputFile(task.file());
+ private CloseableIterable<Record> openFile(
+ FileScanTask task, Schema fileProjection, InputFilesDecryptor decryptor)
{
Map<Integer, ?> partition =
PartitionUtil.constantsMap(task,
IdentityPartitionConverters::convertConstant);
ReadBuilder<Record, ?> builder =
- FormatModelRegistry.readBuilder(task.file().format(), Record.class,
input);
+ FormatModelRegistry.readBuilder(
+ task.file().format(), Record.class,
decryptor.getInputFile(task.file().location()));
Review Comment:
decryption of Avro files (eg avro data) requires file length. Can you verify
it is passed from key metadata to AES GCM Stream reader?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
