singhpk234 commented on code in PR #13979: URL: https://github.com/apache/iceberg/pull/13979#discussion_r4276230255
########## spark/v4.2/spark-extensions/src/main/scala/org/apache/spark/sql/catalyst/analysis/LoadContextTableCatalog.scala: ########## @@ -0,0 +1,61 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.spark.sql.catalyst.analysis + +import org.apache.iceberg.catalog.LoadContext +import org.apache.iceberg.spark.SparkSupportsLoadContext +import org.apache.spark.sql.connector.catalog.Identifier +import org.apache.spark.sql.connector.catalog.Table +import org.apache.spark.sql.connector.catalog.TableCatalog +import org.apache.spark.sql.connector.catalog.TableChange +import org.apache.spark.sql.util.CaseInsensitiveStringMap + +/** + * Catalog for a table read through a view, so that reloads keep the view chain. Spark's table + * version refresh before execution reloads tables by identifier only, using the relation's + * catalog. Only read operations are supported. + */ +private[analysis] case class LoadContextTableCatalog( Review Comment: should i test for this ? i think the existing equals / hashcode should be sufficient ... i am not sure if i fully understand the example though ... i though df.cache() is only used when used in context of df ... is spark.sql will be aware of the cache of df1 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
