mxm commented on code in PR #18477: URL: https://github.com/apache/iceberg/pull/18477#discussion_r4281762778
########## spark/v4.2/spark/src/main/java/org/apache/iceberg/spark/actions/ExpireSnapshotsSparkAction.java: ########## @@ -69,6 +73,10 @@ public class ExpireSnapshotsSparkAction extends BaseSparkAction<ExpireSnapshotsS public static final String STREAM_RESULTS = "stream-results"; public static final boolean STREAM_RESULTS_DEFAULT = false; + public static final String BEST_EFFORT = "best-effort-on-missing-metadata"; + + public static final boolean BEST_EFFORT_DEFAULT = false; Review Comment: I'm not convinced we even need this option. Why would we fail on missing files for snapshots which we are about to expire? Shouldn't the default behavior be to ignore missing files for snapshots which are about to be expire? What do we gain by failing in that scenario? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
