ebyhr commented on code in PR #17111:
URL: https://github.com/apache/iceberg/pull/17111#discussion_r4279171641
##########
gcp/src/main/java/org/apache/iceberg/gcp/GCPProperties.java:
##########
@@ -50,6 +50,14 @@ public class GCPProperties implements Serializable {
*/
public static final String GCS_KMS_KEY_NAME = "gcs.kms-key-name";
+ /**
+ * Configure an alternative endpoint of the KMS service for
GcpKeyManagementClient to access.
+ *
+ * <p>This could be used to use KMS key management with any KMS-compatible
service that has a
+ * different endpoint
Review Comment:
I'm not certain about the practicality of such services in production, but
Trino extensively utilizes https://github.com/floci-io/floci-gcp during its
testing phase. The primary motivation behind this PR originates from Trino.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
