szlta commented on code in PR #17155:
URL: https://github.com/apache/iceberg/pull/17155#discussion_r4271105989
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2157,9 +2157,19 @@ components:
to supply access via any or none of the requested mechanisms.
- Specific properties and handling for `vended-credentials` and
`remote-signing`
+ Specific properties and handling for `vended-credentials`,
`remote-signing`, and `kms-vended-credentials`
are documented in the `LoadTableResult` schema section of this spec
document.
+ `kms-vended-credentials` does not subsume `vended-credentials`.
Clients that support both storage
+ and KMS credential vending should request both mechanisms for
encrypted table operations.
Review Comment:
IMHO this sentence only describes what clients should request for encrypted
operations - it doesn’t require them to identify the table as encrypted before
loading, they obviously can't do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
