wgtmac commented on code in PR #17918: URL: https://github.com/apache/iceberg/pull/17918#discussion_r4268660997
########## format/spec.md: ########## @@ -1511,6 +1543,7 @@ Maps with non-string keys must use an array representation with the `map` logica |**`variant`**|`record` with `metadata` and `value` fields. `metadata` and `value` must not be assigned field IDs and the fields are accessed through names. |Shredding is not supported in Avro.| |**`geometry`**|`bytes`|WKB format, see [Appendix G](#appendix-g-geospatial-notes)| |**`geography`**|`bytes`|WKB format, see [Appendix G](#appendix-g-geospatial-notes)| +|**`file`**|`record` with the `file` sub-fields. Sub-fields must be assigned field IDs. |See [File Type](#file-type). Avro has no `FILE` logical type; type identity comes from the Iceberg schema.| Review Comment: > Avro has no `FILE` logical type Avro does not have `MAP` logical type either but we use logical type name `map` when array storage is used for the map type. Should we do the similar thing for file type by introducing a custom logical type name `file`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
