wroever commented on code in PR #1984:
URL: https://github.com/apache/iceberg-go/pull/1984#discussion_r4266864377
##########
manifest.go:
##########
@@ -917,6 +917,11 @@ func (c *ManifestReader) ReadEntry() (ManifestEntry,
error) {
if c.isFallback {
tmp = tmp.(*fallbackManifestEntry).toEntry()
}
+ if df, ok := tmp.DataFile().(*dataFile); ok {
Review Comment:
Updated - merging latest main brought in #1972, which added the same
unguarded type assertion directly above. Resolving that conflict, I assigned
the data file to a variable once and used it for both:
```go
df := tmp.DataFile().(*dataFile)
df.projected = c.projected
if err := df.normalizeFormat(); err != nil {
return nil, err
}
```
That's the "assert unconditionally" option; nothing can silently skip
normalization now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
