singhpk234 commented on code in PR #18081:
URL: https://github.com/apache/iceberg/pull/18081#discussion_r4266707612
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -1276,6 +1307,27 @@ private FileIO tableFileIO(
return newFileIO(context, fullConf.buildKeepingLast(), storageCredentials);
}
+ private boolean useClientSideStorageAccessForEncryptedTable(TableMetadata
tableMetadata) {
+ return useClientSideStorageAccessForEncryptedTables()
+ && tableMetadata != null
+ &&
tableMetadata.properties().containsKey(TableProperties.ENCRYPTION_TABLE_KEY);
+ }
+
+ private void validateNoServerSideStorageAccess(
Review Comment:
This recent discussion clarified a lot about `X-Iceberg-Access-Delegation`
please check this [1], i applied a small patch on top of your recent push,
Sreesh
https://github.com/apache/iceberg/pull/18081/changes/73ca4c18637a0ec2c3e8bdd4b38e6f6a89d19dd2
let me know if this is something work !
[1] https://lists.apache.org/thread/6zspb6cpb6j2po5lm57mq1sgcp2hppkf
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
