JeonDaehong commented on PR #3432: URL: https://github.com/apache/iceberg-rust/pull/3432#issuecomment-6157621366
Following up on the decimal/uuid part, I checked what Java writes here (iceberg-api, JDK 21). Once the source is dropped, Java sees `UnknownType` and just uses `value.toString()`: | | source present | source dropped | |---|---|---| | `identity(decimal(9,2))` 1.23 | `p=1.23` | `p=1.23` | | `truncate[10](decimal(9,2))` 1.20 | `p=1.20` | `p=1.20` | | `identity(uuid)` | `p=f79c3e09-…` | `p=f79c3e09-…` | | `identity(date)` 19000 | `p=2022-01-08` | `p=19000` | uuid should be easy to match by formatting the `UInt128` as a UUID. decimal is the tricky one: `BigDecimal` keeps its scale, but on our side only the unscaled `Int128` is left, so any fallback would write `p=123` where Java writes `p=1.23`. date already gives `19000` on this branch, same as Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
