dhruvarya-db opened a new pull request, #3441:
URL: https://github.com/apache/iceberg-rust/pull/3441
## Which issue does this PR close?
- Closes #2583.
## What changes are included in this PR?
This adds `Transaction::update_partition_spec()`. Until now the only way to
evolve a partition spec was to build the `AddSpec` update by hand, choosing
every field ID yourself.
```rust
let tx = tx
.update_partition_spec()
.add_field("id", Transform::Bucket(16))
.remove_field("category")
.rename_field("ts_day", "day")
.apply(tx)?;
let table = tx.commit(&catalog).await?;
```
The logic is a port of Java's `BaseUpdatePartitionSpec`, so the same changes
give the same spec as Java, including the default field names (`id_bucket_16`,
`ts_day`) and the error messages.
Field IDs are assigned here rather than left to the catalog. A new field
that matches one in an earlier spec reuses that field's ID, as the spec
requires; a match means the same source column and transform, plus the same
name if one is given. When several fields match, the highest ID wins, as in
Java's `TableMetadata`. Otherwise the field gets the next ID after
`last-partition-id`. The commit sends `AddSpec`, plus `SetDefaultSpec` unless
`add_non_default_spec()` is called. It also asserts the last assigned partition
ID and the default spec ID it started from.
Not covered yet:
- Format version 1 tables are rejected. They keep removed fields as `void`
placeholders, which needs its own handling.
- The spec builder rejects a spec that keeps two time granularities of one
column. So adding `hour(ts)` to a `day(ts)` table fails at commit on catalogs
built on iceberg-rust. #3431 fixes the builder.
## Are these changes tested?
Yes. The unit tests port Java's `TestUpdatePartitionSpec`. The table-level
tests port `TestTableUpdatePartitionSpec`, committing through the memory
catalog.
## AI Disclosure
Written with Claude Opus 5.5 and reviewed by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
