anuragmantri commented on code in PR #3424:
URL: https://github.com/apache/iceberg-rust/pull/3424#discussion_r4263726289
##########
crates/iceberg/src/scan/context.rs:
##########
@@ -52,6 +52,7 @@ pub(crate) struct ManifestFileContext {
partition_spec: Option<PartitionSpecRef>,
unified_partition_type: Option<Arc<StructType>>,
sort_orders: Arc<HashMap<i64, SortOrderRef>>,
+ column_stats_field_ids: Option<Arc<Vec<i32>>>,
Review Comment:
I kept `i32` to match how field ids are typed everywhere else: the spec
defines them as `int`, and `NestedField::id`, the `DataFile` stats maps this
reads from, `FileScanTask::project_field_ids` and `FileMetrics` in #3347 all
use `i32`. Switching here would mean converting at each of those boundaries.
##########
crates/iceberg/src/scan/mod.rs:
##########
@@ -1106,6 +1150,112 @@ mod tests {
);
}
+ /// One column's statistics: field id, value count, null count, NaN count,
lower bound
+ /// and upper bound.
+ type ColumnStat = (i32, u64, u64, Option<u64>, Datum, Datum);
Review Comment:
Right, it's only a test helper, so each column's expected stats fit on one
line. Happy to switch to a small struct if that reads better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
