anuragmantri commented on code in PR #18400:
URL: https://github.com/apache/iceberg/pull/18400#discussion_r4263349870
##########
azure/src/integration/java/org/apache/iceberg/azure/adlsv2/TestADLSFileIO.java:
##########
@@ -169,7 +169,8 @@ public void testListPrefixOperations() {
// assert that only files were returned and not directories
FileInfo fileInfo = result.next();
- assertThat(fileInfo.location()).isEqualTo("dir/file");
+ assertThat(fileInfo.location())
Review Comment:
This now covers `abfs` with a container. Could the test be parameterized
over scheme (`abfs`, `abfss`, `wasb`, `wasbs`) and container presence? The
no-container branch of `fullyQualifiedLocation` has no coverage, and asserting
that each result parses back through `new ADLSLocation(...)` would cover the
round trip. I tried those combinations locally with a mocked client and they
all work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
