kevinjqliu commented on code in PR #15407:
URL: https://github.com/apache/iceberg/pull/15407#discussion_r4262092157


##########
dev/.rat-excludes:
##########
@@ -29,4 +29,5 @@ sitemap.xml
 .python-version
 **/*_index.md
 **/.venv/**
+**/_delta_log/_last_checkpoint

Review Comment:
   i think this means that we are potentially packaging `_delta_log/` in the 
source distribution. i think its better to not do that. we can either generate 
the golden tables at runtime for testing or exclude them from packaging



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to