richiebachala commented on PR #2173: URL: https://github.com/apache/iceberg-go/pull/2173#issuecomment-6152310256
Thanks for the approval @zeroshade. A correction to my last comment: I said I'd open an issue proposing a spec clarification for `from == to`. After digging further, I don't think one is warranted. This was settled deliberately when REST rename was added in apache/iceberg#4448. A draft of `RenameTableRequest` rejected `source == destination`; @rdblue asked whether it should be invalid or a no-op, and the check was dropped so that implementors keep discretion. The `JdbcCatalog` and `InMemoryCatalog` early returns came later (#9487, #6927). Across Java's catalogs, Hive, DynamoDB and ECS reject a self-rename, and JDBC and InMemory no-op, so accepting both outcomes matches upstream intent rather than papering over a gap. 8e354d3 is a comment-only change citing #4448 in `testRenameTableToSelf` so the reasoning lives next to the test. No behavior change; conformance still passes locally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
