YinZheng-Sun commented on PR #956: URL: https://github.com/apache/iceberg-cpp/pull/956#issuecomment-6144278625
> > So now this pr is ready for review, right? @YinZheng-Sun @advancedxy > > I'm submitting the row number reader now. I think we can rebase this pr on that. How about decoupling them so this PR doesn't need to wait 1. In this PR, keep only the statistics-based row group filter (`parquet_metrics_row_group_filter.*`) with its unit tests. It's self-contained and doesn't touch the read path, so it can be reviewed and merged independently. 2. Once the RowPositionReader lands, A follow-up PR to apply the filter in the Parquet reader on top of it. That way `_pos` comes from the row position reader instead of the manual counter, and it also fits better with the future page skipping work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
