rshdhere commented on code in PR #18473:
URL: https://github.com/apache/iceberg/pull/18473#discussion_r4253717685
##########
core/src/test/java/org/apache/iceberg/rest/TestErrorHandlers.java:
##########
@@ -71,6 +73,48 @@ public void errorHandlerWithCodeAndTypeOnly() {
.hasMessage("Unable to process (code: 422, type: ValidationException):
null");
}
+ @Test
+ void badRequestWithValidationExceptionType() {
+ ErrorResponse error =
+ ErrorResponse.builder()
+ .responseCode(400)
+ .withType("ValidationException")
+ .withMessage("Table property commit.retry.num-retries must have
integer value")
+ .build();
+
+ assertThatThrownBy(() -> ErrorHandlers.tableErrorHandler().accept(error))
Review Comment:
Good point. `CommitErrorHandler` has no case for 400, so a 400 falls through
to `DefaultErrorHandler` and hits the new branch too. I've added a test that
runs `tableCommitHandler()` on the same 400 `ValidationException` response
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
