Revanth14 commented on code in PR #18472:
URL: https://github.com/apache/iceberg/pull/18472#discussion_r4253523843
##########
core/src/main/java/org/apache/iceberg/rest/RESTFileScanTaskParser.java:
##########
@@ -94,7 +95,10 @@ public static FileScanTask fromJson(
deleteFiles =
indices.stream().map(allDeleteFiles::get).toArray(DeleteFile[]::new);
}
- Expression filter = null;
+ // A missing residual-filter is allowed by the spec, and the client must
then produce the
+ // residual: the ResidualEvaluator below derives it from the scan filter
and the task's
+ // partition.
Review Comment:
agreed, updated the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
