zhjwpku commented on code in PR #774: URL: https://github.com/apache/iceberg-cpp/pull/774#discussion_r4249796285
########## src/iceberg/manifest/manifest_util.cc: ########## @@ -68,4 +68,35 @@ Result<ManifestFile> CopyAppendManifest( return writer->ToManifestFile(); } +Result<ManifestFile> CopyRewriteManifest( Review Comment: I took a closer look at `CopyAppendManifest`. The implementations are similar, but their parameters and behavior differ, I don't see a clean way to extract a common helper :( -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
