zhjwpku commented on code in PR #774:
URL: https://github.com/apache/iceberg-cpp/pull/774#discussion_r4243917487
##########
src/iceberg/update/snapshot_update.h:
##########
@@ -104,6 +104,11 @@ class ICEBERG_EXPORT SnapshotUpdate : public PendingUpdate
{
return self.AddError(ErrorKind::kInvalidArgument, "Branch name cannot be
empty");
}
+ if (auto status =
static_cast<SnapshotUpdate&>(self).ValidateTargetBranch(branch);
Review Comment:
This hook lets derived snapshot updates validate branch support while
reusing ToBranch. RewriteManifests uses it to preserve Java's
unsupported-branch behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
