dannycjones commented on code in PR #3389:
URL: https://github.com/apache/iceberg-rust/pull/3389#discussion_r4242486210
##########
.github/workflows/ci.yml:
##########
@@ -122,6 +122,9 @@ jobs:
- name: Cargo clippy
run: make check-clippy
+ - name: Cargo doc
+ run: make check-doc
Review Comment:
So... I think this job (`clippy`) is arguably better than `lint` to put this
check, given its actually quite heavy (it needs to do macros, type checking,
etc.)...
That being said, I think we need to rename the job. Maybe "clippy-and-docs".
Whatever.
Another idea I have is that we could explore having a few jobs, where it
could reuse artifacts from the last? But we should verify the reuse actually
occurs if we go down that route. I could imagine "lint" -> "check" -> "clippy",
"docs". I'm inclined however to just get this merged in a simple way and we can
rework the workflows if we have stronger opinions later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
