amogh-jahagirdar commented on code in PR #18434:
URL: https://github.com/apache/iceberg/pull/18434#discussion_r4242937765
##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/TestVectorizedReaderBuilder.java:
##########
@@ -70,6 +72,41 @@ public void testVariantSkippedWhenNotInProjection() {
() -> TypeWithSchemaVisitor.visit(icebergSchema.asStruct(),
parquetSchema, builder));
}
+ @Test
+ public void testShreddedVariantSkippedWhenNotInProjection() {
Review Comment:
I think it's worth adding a parameterized test for when the variant is
nested inside struct, as a list element, map key/value and isn't projected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
