pvary opened a new pull request, #18441:
URL: https://github.com/apache/iceberg/pull/18441

   During the discussion on #18405 I have found that we are mixing relative and 
absolute URLs in the specs. Since relative URLs work for both GitHub and on the 
side (MkDocs handles them correctly), I suggest to standardize on them.
   
   The snapshot structure image in `spec.md` still uses the absolute URL, 
because `assets/images/` exists only under `site/docs/` and would not render on 
GitHub.
   
   Checked the whole site for broken links too, and fixed them.
   
   Testing: I built the site locally with `make serve-dev` and crawled every 
link and anchor on the 7 spec pages. Internal and external links all resolve, 
except two `../javadoc/{{ icebergVersion }}/...` links in `spec.md`. These fail 
only because the dev build leaves out versioned javadoc, and both resolve on 
iceberg.apache.org.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to