LuciferYang commented on PR #982: URL: https://github.com/apache/iceberg-cpp/pull/982#issuecomment-6097839202
> LGTM. > > Agent alerted me there's one other similar failure issue during the code review: > > https://github.com/apache/iceberg-cpp/blob/b4eecba1e2a9ca3ef9926f07d5a76b0f85981f94/src/iceberg/json_serde.cc#L496-L505 > > 's TypeFromJson accesses `json[kElement]` directly without check its existence, which also triggers SIGABRT. It should follow the MapTypeFromJson's [practice](https://github.com/apache/iceberg-cpp/blob/b4eecba1e2a9ca3ef9926f07d5a76b0f85981f94/src/iceberg/json_serde.cc#L510). would you mind to submit a follow-up pr as well? Yes, will fix in a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
