Sruhvx-jpg commented on PR #3165: URL: https://github.com/apache/iceberg-rust/pull/3165#issuecomment-6094651306
Thanks for the detailed review @laskov! All addressed in the latest push: - **Env Seeding**: Seeded `AmazonS3Builder::from_env()` so `AWS_*` env variables load before explicit `S3Config` overrides. - **Path Parsing & Verification**: Switched to `ObjectStorePath::parse` (`dt=a%2Fb` no longer double-encodes to `%252F`). Added raw bucket listing assertions in the integration test to verify exact on-wire S3 keys. - **SSE Matcher Tightened**: Removed bare `"kms"` substring matching in `assert_minio_kms_rejection` (fixing URL path false positives) and updated `test_file_io_s3_sse_s3_aes256` to strictly require deterministic KES-less 501 rejection. - **`#[non_exhaustive]` & Property Constants**: Added `#[non_exhaustive]` to `ObjectStoreStorage` and `ObjectStoreStorageFactory`. Moved `S3_DELETE_BATCH_SIZE` to `iceberg::io` and made internal batch limits `pub(crate)`. - **Cancellation Safety in `close()`**: Borrowed `self.upload.as_mut()` through async completion points, only taking ownership on success so RAII `Drop` aborts if cancelled mid-await. - **Configurable Part Sizing**: Added `s3.multipart.part-size-bytes` (`S3_MULTIPART_PART_SIZE_BYTES`) defaulting to 32 MiB (5 MiB floor) for Java spec parity, raising default capacity to ~312.5 GiB. - **Mock Abort Assertions**: Refactored test mocks to atomic counters (`Arc<AtomicUsize>`) and asserted `abort_count == 1` across all error/panic paths. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
