amogh-jahagirdar commented on code in PR #18418:
URL: https://github.com/apache/iceberg/pull/18418#discussion_r4233202204
##########
core/src/main/java/org/apache/iceberg/ManifestInfoStruct.java:
##########
@@ -376,6 +393,13 @@ Builder dv(ByteBuffer buffer) {
return this;
}
+ Builder formatVersion(int version) {
+ Preconditions.checkArgument(
+ version == 0 || version == 4, "Invalid format version: %s (must be 0
or 4)", version);
Review Comment:
See this just got merged, no big deal but I'd +1 @nastra point. While we
expect only 0 or 4, the implementation can always be more liberal in terms of
what it accepts, and having it be >= 4 is a small thing that helps this code
"just work" for future format versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
