dannycjones commented on code in PR #3379: URL: https://github.com/apache/iceberg-rust/pull/3379#discussion_r4233342845
########## dev/release/licenses.py: ########## @@ -0,0 +1,101 @@ +#!/usr/bin/env python3 +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +CLI for assisting maintenance of the project's license checks. +""" + +import argparse +import subprocess +import sys +from pathlib import Path + +REPO_ROOT = Path(__file__).resolve().parent.parent.parent + + +class Failure(Exception): + """A user-facing error.""" + + +def step(message: str) -> None: + print(f"==> {message}", flush=True) + + +def ok(message: str) -> None: + print(f"OK: {message}", flush=True) + + +def require_cargo_deny() -> None: + """Assert cargo-deny is installed.""" + try: + subprocess.run( + ["cargo", "deny", "--version"], + capture_output=True, + check=True, + ) + except FileNotFoundError: + raise Failure("This script requires 'cargo', but it is not installed.") + except subprocess.CalledProcessError: + raise Failure( + "This script requires 'cargo-deny' for dependency license checks.\n" + "Install it with: cargo install --locked cargo-deny" Review Comment: I'll update to suggest `make install-cargo-deny`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
