danielcweeks commented on code in PR #18019:
URL: https://github.com/apache/iceberg/pull/18019#discussion_r4232874660
##########
kafka-connect/build.gradle:
##########
@@ -120,11 +121,18 @@
project(':iceberg-kafka-connect:iceberg-kafka-connect-runtime') {
implementation project(':iceberg-orc')
implementation project(':iceberg-parquet')
+ // The cloud SDK dependencies below mirror the dependency lists of the
+ // iceberg-aws-bundle, iceberg-gcp-bundle and iceberg-azure-bundle
projects, so
+ // the distribution offers the same features as the bundles and its
LICENSE and
+ // NOTICE content can be kept in sync with theirs. The bundle jars
themselves are
+ // not shipped: they would duplicate every class already present as a
loose jar.
implementation project(':iceberg-aws')
implementation platform(libs.awssdk.bom)
+ implementation libs.awssdk.s3accessgrants
implementation 'software.amazon.awssdk:apache-client'
implementation 'software.amazon.awssdk:auth'
- implementation "software.amazon.awssdk:http-auth-aws-crt"
Review Comment:
Rather than calling out the specific libraries, can't we use a project
reference (e.g.
`project(':iceberg-aws-bundle').configurations.runtimeClasspath`). Individual
references just feels like it's going to get out of sync over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
