wgtmac commented on PR #936: URL: https://github.com/apache/iceberg-cpp/pull/936#issuecomment-6078372055
Thanks for the work on this, @PingLiuPing! The PR was already largely working, so I went ahead and pushed a revised version directly to the branch to save a few review round trips. The main change is that C++23 stays as the default API, while C++20 is now an explicit opt-in mode via `ICEBERG_CXX20_COMPAT`. This avoids switching public types based on `__cplusplus`, which could create ODR problems or leave the library and downstream application with different assumptions. The compatibility code is grouped under `iceberg/compat`; the original C++23 fluent APIs are preserved, while C++20 gets clear fallbacks. I also simplified the tests, examples, docs, and CI setup, and made the build scripts use named parameters instead of long positional ON/OFF lists. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
